Skip to content

API Reference > Test Utilities#45

Merged
saranshkataria merged 43 commits into
reactjs:masterfrom
paramaggarwal:addons-test-utils
Jun 13, 2020
Merged

API Reference > Test Utilities#45
saranshkataria merged 43 commits into
reactjs:masterfrom
paramaggarwal:addons-test-utils

Conversation

@paramaggarwal

@paramaggarwal paramaggarwal commented Aug 23, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Overview
  • Reference
    • act()
    • mockComponent()
    • isElement()
    • isElementOfType()
    • isDOMComponent()
    • isCompositeComponent()
    • isCompositeComponentWithType()
    • findAllInRenderedTree()
    • scryRenderedDOMComponentsWithClass()
    • findRenderedDOMComponentWithClass()
    • scryRenderedDOMComponentsWithTag()
    • findRenderedDOMComponentWithTag()
    • scryRenderedComponentsWithType()
    • findRenderedComponentWithType()
    • renderIntoDocument()
  • Other Utilities
    • Simulate

@netlify

netlify Bot commented Aug 23, 2019

Copy link
Copy Markdown

Deploy preview for hi-reactjs ready!

Built with commit c40d883

https://deploy-preview-45--hi-reactjs.netlify.com

@netlify

netlify Bot commented Aug 23, 2019 •
edited
Loading

Copy link
Copy Markdown

Deploy preview for hi-reactjs ready!

Built with commit 0eaa33c

https://deploy-preview-45--hi-reactjs.netlify.app

@arshadkazmi42

arshadkazmi42 commented Aug 23, 2019

Copy link
Copy Markdown
Member

@paramaggarwal Good start. Let me know once you are done translating the whole file. I will start the review

@paramaggarwal paramaggarwal changed the title [WIP] API Reference > Test Utilities API Reference > Test Utilities Sep 16, 2019
@arshadkazmi42

arshadkazmi42 commented Sep 16, 2019

Copy link
Copy Markdown
Member

Ready.

Awesome. I will start reviewing this later today.

arshadkazmi42
arshadkazmi42 requested changes Sep 16, 2019
View reviewed changes

@arshadkazmi42 arshadkazmi42 left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start.
I have added some feedbacks till line 124.

For review process do read #23

Comment thread content/docs/addons-test-utils.md Outdated
Comment thread content/docs/addons-test-utils.md Outdated
Comment thread content/docs/addons-test-utils.md Outdated
Comment thread content/docs/addons-test-utils.md Outdated
Comment thread content/docs/addons-test-utils.md Outdated
Comment thread content/docs/addons-test-utils.md Outdated
Comment thread content/docs/addons-test-utils.md Outdated
@paramaggarwal

paramaggarwal commented Sep 17, 2019

Copy link
Copy Markdown
Contributor Author

Thanks for the excellent feedback. I have addressed everything raised till now. We can continue further review.

arshadkazmi42
arshadkazmi42 requested changes Sep 17, 2019
View reviewed changes

@arshadkazmi42 arshadkazmi42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work with the fixes.
I have reviewed the whole file and add couple of more feedbacks.
Once these are fixed it will be good to go from my end for second phase of review

Comment thread content/docs/addons-test-utils.md Outdated
Comment thread content/docs/addons-test-utils.md Outdated
Comment thread content/docs/addons-test-utils.md Outdated
Comment thread content/docs/addons-test-utils.md Outdated
Comment thread content/docs/addons-test-utils.md Outdated
Comment thread content/docs/addons-test-utils.md Outdated
Comment thread content/docs/addons-test-utils.md Outdated
Comment thread content/docs/addons-test-utils.md Outdated
Comment thread content/docs/addons-test-utils.md Outdated
Comment thread content/docs/addons-test-utils.md Outdated
arshadkazmi42
arshadkazmi42 approved these changes Sep 18, 2019
View reviewed changes

@arshadkazmi42 arshadkazmi42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 💯
This is good to go from my end.
For next steps, there will be a second round of review done by @saranshkataria. Once that is done, we will get this merged

@paramaggarwal

paramaggarwal commented Jan 15, 2020

Copy link
Copy Markdown
Contributor Author

Comments addressed. Sorry for previously marking comments as "Resolved" - have not done so this time.

@arshadkazmi42 arshadkazmi42 added the 2nd Review Second phrase of review label Jan 24, 2020
@saranshkataria

saranshkataria commented Feb 17, 2020

Copy link
Copy Markdown
Contributor

@paramaggarwal this has become confusing a bit to check which ones were resolved and which ones were not. Marking everything as resolved and starting the review afresh.

saranshkataria
saranshkataria reviewed Feb 17, 2020
View reviewed changes

@saranshkataria saranshkataria left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added comments till line 220

Comment thread content/docs/addons-test-utils.md Outdated
Comment thread content/docs/addons-test-utils.md Outdated
Comment thread content/docs/addons-test-utils.md Outdated
Comment thread content/docs/addons-test-utils.md Outdated
@saranshkataria

saranshkataria commented Apr 11, 2020

Copy link
Copy Markdown
Contributor

@paramaggarwal there are quite a few pending points. Could you look into those as well before we proceed with the review?

@paramaggarwal

paramaggarwal commented May 15, 2020

Copy link
Copy Markdown
Contributor Author

Ready.

saranshkataria
saranshkataria reviewed May 22, 2020
View reviewed changes
Comment thread content/docs/addons-test-utils.md Outdated
saranshkataria
saranshkataria reviewed May 22, 2020
View reviewed changes

@saranshkataria saranshkataria left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added final set of changes needed. Then this will be good to 👍

Comment thread content/docs/addons-test-utils.md Outdated
Comment thread content/docs/addons-test-utils.md Outdated
Comment thread content/docs/addons-test-utils.md Outdated
@paramaggarwal

paramaggarwal commented Jun 4, 2020

Copy link
Copy Markdown
Contributor Author

Ready.

@saranshkataria

saranshkataria commented Jun 13, 2020

Copy link
Copy Markdown
Contributor

LGTM, Thanks! Merging it in

@saranshkataria
saranshkataria merged commit 3add710 into reactjs:master Jun 13, 2020
@paramaggarwal

paramaggarwal commented Jun 14, 2020

Copy link
Copy Markdown
Contributor Author

Thanks a lot @saranshkataria and @arshadkazmi42 👍

@paramaggarwal
paramaggarwal deleted the addons-test-utils branch June 14, 2020 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arshadkazmi42 arshadkazmi42 arshadkazmi42 approved these changes
+1 more reviewer
@saranshkataria saranshkataria saranshkataria approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2nd Review Second phrase of review awaiting author response

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paramaggarwal @arshadkazmi42 @saranshkataria